🛡️ Sentinel: [HIGH] Fix Zip Slip vulnerability in batch ZIP generation - #345

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

_{Comment @coderabbitai help to get the list of available commands.}

@opencode-agent @cwl-noema-review

Rebuild this Draft from exact protected current main. Remove .github/workflows/repair-pr-345.yml, encoded patches, and every one-shot branch writer. Implement one centralized, documented filename-boundary function used by single upload, batch upload, async upload, result naming, and ZIP member creation. Treat both / and \\ as separators regardless of runner OS; reject or deterministically replace empty, ., .., NUL/control characters, absolute/drive/UNC syntax, trailing Windows dot/space ambiguity, reserved device names, and unsafe normalization results; preserve a safe extension where possible; prevent case-insensitive and normalization-equivalent collisions inside a batch by deterministic unique naming; never expose original hostile paths in errors. Add direct property/fuzz tests and end-to-end ZIP tests that inspect every member as both POSIX and Windows paths, then extract with representative standard libraries into a bounded temp root and prove no escape/overwrite. Preserve current dynamic upload limits, total batch-size validation, cleanup behavior, accessibility, and all accepted security fixes. Add CWE-22/ZIP archive/Windows path doctoring with APA 7 primary references, update the current Unreleased changelog, and run hash-pinned install, focused/complete tests, 100% production statement/branch coverage, production docstrings, compilation, fuzz/property tests, package smoke, security/SAST, and git diff --check. Publish a normal source commit only. Do not merge, approve, release, alter protections, or retain duplicate filename sanitizers.

Superseded by #371. This old-base Draft handles only one backslash traversal example and does not define a complete cross-platform filename or ZIP-member boundary. The replacement issue covers all upload/result/archive call sites, Windows drive/UNC/device and trailing-dot semantics, Unicode/case collisions, deterministic duplicate naming, bounded extraction tests, 100% coverage/docstrings, and CSAP/SOC 2 evidence. Closing without merge avoids treating a partial security patch as complete remediation.

@opencode-agent @cwl-noema-review

Rebuild this Draft from exact protected current main. Remove .github/workflows/repair-pr-345.yml, encoded patches, and every one-shot branch writer. Implement one centralized, documented filename-boundary function used by single upload, batch upload, async upload, result naming, and ZIP member creation. Treat both / and \\ as separators regardless of runner OS; reject or deterministically replace empty, ., .., NUL/control characters, absolute/drive/UNC syntax, trailing Windows dot/space ambiguity, reserved device names, and unsafe normalization results; preserve a safe extension where possible; prevent case-insensitive and normalization-equivalent collisions inside a batch by deterministic unique naming; never expose original hostile paths in errors. Add direct property/fuzz tests and end-to-end ZIP tests that inspect every member as both POSIX and Windows paths, then extract with representative standard libraries into a bounded temp root and prove no escape/overwrite. Preserve current dynamic upload limits, total batch-size validation, cleanup behavior, accessibility, and all accepted security fixes. Add CWE-22/ZIP archive/Windows path doctoring with APA 7 primary references, update the current Unreleased changelog, and run hash-pinned install, focused/complete tests, 100% production statement/branch coverage, production docstrings, compilation, fuzz/property tests, package smoke, security/SAST, and git diff --check. Publish a normal source commit only. Do not merge, approve, release, alter protections, or retain duplicate filename sanitizers.

Understood. The request has been superseded and this work is now obsolete. Stopping work on this task.

Superseded by #371. This old-base Draft handles only one backslash traversal example and does not define a complete cross-platform filename or ZIP-member boundary. The replacement issue covers all upload/result/archive call sites, Windows drive/UNC/device and trailing-dot semantics, Unicode/case collisions, deterministic duplicate naming, bounded extraction tests, 100% coverage/docstrings, and CSAP/SOC 2 evidence. Closing without merge avoids treating a partial security patch as complete remediation.

Acknowledged. Closing this out as obsolete since it has been superseded by a complete cross-platform fix in #371.